terraform.gcp.security.gcp-sub-network-private-google-enabled.gcp-sub-network-private-google-enabled

profile photo of semgrepsemgrep
Author
unknown
Download Count*

Ensure that private_ip_google_access is enabled for Subnet

Run Locally

Run in CI

Defintion

rules:
  - id: gcp-sub-network-private-google-enabled
    patterns:
      - pattern: resource
      - pattern-inside: |
          resource "google_compute_subnetwork" "..." {
          ...
          }
      - pattern-not-inside: |
          resource "google_compute_subnetwork" "..." {
          ...
          private_ip_google_access = true
          ...
          }
    message: Ensure that private_ip_google_access is enabled for Subnet
    metadata:
      owasp:
        - A05:2017 - Broken Access Control
        - A01:2021 - Broken Access Control
      cwe:
        - "CWE-284: Improper Access Control"
      category: security
      technology:
        - terraform
        - gcp
      references:
        - https://owasp.org/Top10/A01_2021-Broken_Access_Control
      subcategory:
        - audit
      likelihood: LOW
      impact: LOW
      confidence: LOW
      license: Commons Clause License Condition v1.0[LGPL-2.1-only]
      vulnerability_class:
        - Improper Authorization
    languages:
      - hcl
    severity: WARNING

Examples

gcp-sub-network-private-google-enabled.tf

# ok: gcp-sub-network-private-google-enabled
resource "google_compute_subnetwork" "pass" {
  name          = "example"
  ip_cidr_range = "10.0.0.0/16"
  network       = "google_compute_network.vpc.self_link"

  log_config {
    aggregation_interval = "INTERVAL_10_MIN"
    flow_sampling        = 0.5
    metadata             = "INCLUDE_ALL_METADATA"
  }
  private_ip_google_access = true
}

# fail
# ruleid: gcp-sub-network-private-google-enabled
resource "google_compute_subnetwork" "fail1" {
  name          = "example"
  ip_cidr_range = "10.0.0.0/16"
  network       = "google_compute_network.vpc.id"
}

# fail
# ruleid: gcp-sub-network-private-google-enabled
resource "google_compute_subnetwork" "fail2" {
  name                     = "example"
  ip_cidr_range            = "10.0.0.0/16"
  network                  = "google_compute_network.vpc.id"
  private_ip_google_access = false
}