terraform.gcp.security.gcp-sub-network-logging-enabled.gcp-sub-network-logging-enabled

profile photo of semgrepsemgrep
Author
unknown
Download Count*
LGPL Commons Clause
License

Ensure that VPC Flow Logs is enabled for every subnet in a VPC Network

Run Locally

Run in CI

Semgrep CI docs

Defintion

Edit RuleView Source
Open in Playground 
rules:
  - id: gcp-sub-network-logging-enabled
    patterns:
      - pattern: |
          resource "google_compute_subnetwork" $ANYTHING {
            ...
          }
      - pattern-not-inside: |
          resource "google_compute_subnetwork" $ANYTHING {
            ...
            log_config {
              ...
            }        
            ...
          }
    message: Ensure that VPC Flow Logs is enabled for every subnet in a VPC Network
    languages:
      - hcl
    severity: WARNING
    metadata:
      owasp:
        - A05:2017 - Broken Access Control
        - A01:2021 - Broken Access Control
      cwe:
        - "CWE-284: Improper Access Control"
      technology:
        - terraform
        - gcp
      category: security
      references:
        - https://owasp.org/Top10/A01_2021-Broken_Access_Control
      subcategory:
        - audit
      likelihood: LOW
      impact: LOW
      confidence: LOW
      license: Commons Clause License Condition v1.0[LGPL-2.1-only]
      vulnerability_class:
        - Improper Authorization

Examples

gcp-sub-network-logging-enabled.tf

# ok: gcp-sub-network-logging-enabled
resource "google_compute_subnetwork" "enabled" {
  name          = "example"
  ip_cidr_range = "10.0.0.0/16"
  network       = "google_compute_network.vpc.self_link"

  log_config {
    aggregation_interval = "INTERVAL_10_MIN"
    flow_sampling        = 0.5
    metadata             = "INCLUDE_ALL_METADATA"
  }
}

# fail
# ruleid: gcp-sub-network-logging-enabled
resource "google_compute_subnetwork" "default" {
  name          = "example"
  ip_cidr_range = "10.0.0.0/16"
  network       = "google_compute_network.vpc.id"
}