terraform.gcp.security.gcp-storage-bucket-uniform-access.gcp-storage-bucket-uniform-access

profile photo of semgrepsemgrep
Author
unknown
Download Count*
LGPL Commons Clause
License

Ensure that Cloud Storage buckets have uniform bucket-level access enabled

Run Locally

Run in CI

Semgrep CI docs

Defintion

Edit RuleView Source
Open in Playground 
rules:
  - id: gcp-storage-bucket-uniform-access
    patterns:
      - pattern: resource
      - pattern-inside: |
          resource "google_storage_bucket" "..." {
          ...
          }
      - pattern-not-inside: |
          resource "google_storage_bucket" "..." {
          ...
          uniform_bucket_level_access = true
          ...
          }
    message: Ensure that Cloud Storage buckets have uniform bucket-level access enabled
    metadata:
      owasp:
        - A05:2017 - Broken Access Control
        - A01:2021 - Broken Access Control
      cwe:
        - "CWE-284: Improper Access Control"
      category: security
      technology:
        - terraform
        - gcp
      references:
        - https://owasp.org/Top10/A01_2021-Broken_Access_Control
      subcategory:
        - audit
      likelihood: LOW
      impact: LOW
      confidence: LOW
      license: Commons Clause License Condition v1.0[LGPL-2.1-only]
      vulnerability_class:
        - Improper Authorization
    languages:
      - hcl
    severity: WARNING

Examples

gcp-storage-bucket-uniform-access.tf

# ok: gcp-storage-bucket-uniform-access
resource "google_storage_bucket" "enabled" {
  name     = "example"
  location = "EU"
  uniform_bucket_level_access = true
}

# fail
# ruleid: gcp-storage-bucket-uniform-access
resource "google_storage_bucket" "default" {
  name     = "example.com"
  location = "EU"
}

# fail
# ruleid: gcp-storage-bucket-uniform-access
resource "google_storage_bucket" "disabled" {
  name     = "example"
  location = "EU"
  uniform_bucket_level_access = false
}