terraform.gcp.security.gcp-run-private-service-iam-binding.gcp-run-private-service-iam-binding

profile photo of semgrepsemgrep
Author
unknown
Download Count*
LGPL Commons Clause
License

Ensure that GCP Cloud Run services are not anonymously or publicly accessible

Run Locally

Run in CI

Semgrep CI docs

Defintion

Edit RuleView Source
Open in Playground 
rules:
  - id: gcp-run-private-service-iam-binding
    patterns:
      - pattern: resource
      - pattern-either:
          - pattern-inside: |
              resource "google_cloud_run_service_iam_binding" "..." {
              ...
              members = [ ..., "allAuthenticatedUsers", ...]
              ...
              }
          - pattern-inside: |
              resource "google_cloud_run_service_iam_binding" "..." {
              ...
              members = [ ..., "allUsers", ...]
              ...
              }
    message: Ensure that GCP Cloud Run services are not anonymously or publicly
      accessible
    metadata:
      owasp:
        - A05:2017 - Broken Access Control
        - A01:2021 - Broken Access Control
      cwe:
        - "CWE-284: Improper Access Control"
      category: security
      technology:
        - terraform
        - gcp
      references:
        - https://owasp.org/Top10/A01_2021-Broken_Access_Control
      subcategory:
        - audit
      likelihood: LOW
      impact: LOW
      confidence: LOW
      license: Commons Clause License Condition v1.0[LGPL-2.1-only]
      vulnerability_class:
        - Improper Authorization
    languages:
      - hcl
    severity: WARNING

Examples

gcp-run-private-service-iam-binding.tf

# ok: gcp-run-private-service-iam-binding
resource "google_cloud_run_service_iam_binding" "pass1" {
  location = google_cloud_run_service.default.location
  service = google_cloud_run_service.default.name
  role = "roles/viewer"
  members = [
    "user:jane@example.com",
    "group:mygroup@example.com",
  ]
}

# ok: gcp-run-private-service-iam-binding
resource "google_cloud_run_service_iam_binding" "pass2" {
  location = google_cloud_run_service.default.location
  service = google_cloud_run_service.default.name
  role = "roles/viewer"
  members = [
    "user:jason@example.com",
  ]
}

# fail
# ruleid: gcp-run-private-service-iam-binding
resource "google_cloud_run_service_iam_binding" "fail1" {
  location = google_cloud_run_service.default.location
  service = google_cloud_run_service.default.name
  role = "roles/viewer"
  members = [
    "allAuthenticatedUsers",
  ]
}

# fail
# ruleid: gcp-run-private-service-iam-binding
resource "google_cloud_run_service_iam_binding" "fail2" {
  location = google_cloud_run_service.default.location
  service = google_cloud_run_service.default.name
  role = "roles/viewer"
  members = [
    "allUsers",
  ]
}

# fail
# ruleid: gcp-run-private-service-iam-binding
resource "google_cloud_run_service_iam_binding" "fail3" {
  location = google_cloud_run_service.default.location
  service = google_cloud_run_service.default.name
  role = "roles/viewer"
  members = [
    "allUsers",
    "user:jason@example.com",
  ]
}

# fail
# ruleid: gcp-run-private-service-iam-binding
resource "google_cloud_run_service_iam_binding" "fail4" {
  location = google_cloud_run_service.default.location
  service = google_cloud_run_service.default.name
  role = "roles/viewer"
  members = [
    "user:jason@example.com",
    "allAuthenticatedUsers",
  ]
}

# fail
# ruleid: gcp-run-private-service-iam-binding
resource "google_cloud_run_service_iam_binding" "fail5" {
  location = google_cloud_run_service.default.location
  service = google_cloud_run_service.default.name
  role = "roles/viewer"
  members = [
    "user:jason@example.com",
    "allAuthenticatedUsers",
    "domain:example.com",
  ]
}