terraform.gcp.security.gcp-pubsub-private-topic-iam-binding.gcp-pubsub-private-topic-iam-binding

profile photo of semgrepsemgrep
Author
unknown
Download Count*

Ensure that Pub/Sub Topics are not anonymously or publicly accessible

Run Locally

Run in CI

Defintion

rules:
  - id: gcp-pubsub-private-topic-iam-binding
    patterns:
      - pattern: resource
      - pattern-either:
          - pattern-inside: |
              resource "google_pubsub_topic_iam_binding" "..." {
              ...
              members = [ ..., "allAuthenticatedUsers", ...]
              ...
              }
          - pattern-inside: |
              resource "google_pubsub_topic_iam_binding" "..." {
              ...
              members = [ ..., "allUsers", ...]
              ...
              }
    message: Ensure that Pub/Sub Topics are not anonymously or publicly accessible
    metadata:
      owasp:
        - A05:2017 - Broken Access Control
        - A01:2021 - Broken Access Control
      cwe:
        - "CWE-284: Improper Access Control"
      category: security
      technology:
        - terraform
        - gcp
      references:
        - https://owasp.org/Top10/A01_2021-Broken_Access_Control
      subcategory:
        - audit
      likelihood: LOW
      impact: LOW
      confidence: LOW
      license: Commons Clause License Condition v1.0[LGPL-2.1-only]
      vulnerability_class:
        - Improper Authorization
    languages:
      - hcl
    severity: WARNING

Examples

gcp-pubsub-private-topic-iam-binding.tf

# ok: gcp-pubsub-private-topic-iam-binding
resource "google_pubsub_topic_iam_binding" "pass1" {
  cluster = "my-private-topic-binding1"
  role    = "roles/pubsub.admin"
  members = [
    "user:jane@example.com",
    "group:mygroup@example.com",
  ]
}

# ok: gcp-pubsub-private-topic-iam-binding
resource "google_pubsub_topic_iam_binding" "pass2" {
  cluster = "my-private-topic-binding2"
  role    = "roles/pubsub.editor"
  members = [
    "user:jason@example.com",
  ]
}

# fail
# ruleid: gcp-pubsub-private-topic-iam-binding
resource "google_pubsub_topic_iam_binding" "fail1" {
  cluster = "my-public-topic-binding1"
  role    = "roles/pubsub.viewer"
  members = [
    "allAuthenticatedUsers",
  ]
}

# fail
# ruleid: gcp-pubsub-private-topic-iam-binding
resource "google_pubsub_topic_iam_binding" "fail2" {
  cluster = "my-public-topic-binding2"
  role    = "roles/pubsub.admin"
  members = [
    "allUsers",
  ]
}

# fail
# ruleid: gcp-pubsub-private-topic-iam-binding
resource "google_pubsub_topic_iam_binding" "fail3" {
  cluster = "my-public-topic-binding3"
  role    = "roles/pubsub.editor"
  members = [
    "allUsers",
    "user:jason@example.com",
  ]
}

# fail
# ruleid: gcp-pubsub-private-topic-iam-binding
resource "google_pubsub_topic_iam_binding" "fail4" {
  cluster = "my-public-topic-binding4"
  role    = "roles/pubsub.publisher"
  members = [
    "user:jason@example.com",
    "allAuthenticatedUsers",
  ]
}