terraform.gcp.security.gcp-gke-basic-auth.gcp-gke-basic-auth

profile photo of semgrepsemgrep
Author
unknown
Download Count*
LGPL Commons Clause
License

Ensure GKE basic auth is disabled

Run Locally

Run in CI

Semgrep CI docs

Defintion

Edit RuleView Source
Open in Playground 
rules:
  - id: gcp-gke-basic-auth
    patterns:
      - pattern: resource
      - pattern-inside: |
          resource "google_container_cluster" "..." {
          ...
          }
      - pattern-not-inside: |
          resource "google_container_cluster" "..." {
          ...
          master_auth {
            client_certificate_config {
              ...
            }
          }
          ...
          }
      - pattern-not-inside: |
          resource "google_container_cluster" "..." {
          ...
          master_auth {
            ...
            username = ""
            password = ""
            ...
          }
          ...
          }
    message: "Ensure GKE basic auth is disabled\t"
    metadata:
      owasp:
        - A05:2017 - Broken Access Control
        - A01:2021 - Broken Access Control
      cwe:
        - "CWE-284: Improper Access Control"
      category: security
      technology:
        - terraform
        - gcp
      references:
        - https://owasp.org/Top10/A01_2021-Broken_Access_Control
      subcategory:
        - audit
      likelihood: LOW
      impact: LOW
      confidence: LOW
      license: Commons Clause License Condition v1.0[LGPL-2.1-only]
      vulnerability_class:
        - Improper Authorization
    languages:
      - hcl
    severity: WARNING

Examples

gcp-gke-basic-auth.tf

# fail
# ruleid: gcp-gke-basic-auth
resource "google_container_cluster" "fail1" {
  name               = "marcellus-wallace"
  location           = "us-central1-a"
  initial_node_count = 3

  timeouts {
    create = "30m"
    update = "40m"
  }
}

# fail
# ruleid: gcp-gke-basic-auth
resource "google_container_cluster" "fail2" {
  name               = "google_cluster_bad"
  monitoring_service = "none"
  enable_legacy_abac = True
  master_authorized_networks_config {
    cidr_blocks {
      cidr_block   = "0.0.0.0/0"
      display_name = "The world"
    }
  }

  master_auth {
    username = "test"
    password = "password"
  }

}

# fail
# ruleid: gcp-gke-basic-auth
resource "google_container_cluster" "fail3" {
  name               = "google_cluster"
  monitoring_service = "monitoring.googleapis.com"
  master_authorized_networks_config {}
}

# ok: gcp-gke-basic-auth
resource "google_container_cluster" "pass" {
  name               = "google_cluster"
  monitoring_service = "monitoring.googleapis.com"
  master_authorized_networks_config {}
  master_auth {
    client_certificate_config {
      issue_client_certificate = false
    }
  }
}

# ok: gcp-gke-basic-auth
resource "google_container_cluster" "pass2" {
  name               = "google_cluster"
  monitoring_service = "monitoring.googleapis.com"
  master_authorized_networks_config {}
  master_auth {
    username = ""
    password = ""
    client_certificate_config {
      issue_client_certificate = false
    }
  }
}