terraform.gcp.security.gcp-datafusion-stack-driver-logging.gcp-datafusion-stack-driver-logging

profile photo of semgrepsemgrep
Author
unknown
Download Count*

Ensure Datafusion has stack driver logging enabled.

Run Locally

Run in CI

Defintion

rules:
  - id: gcp-datafusion-stack-driver-logging
    patterns:
      - pattern-inside: |
          resource "google_data_fusion_instance" $ANYTHING {
            ...
          }
      - pattern-not-inside: |
          resource "google_data_fusion_instance" $ANYTHING {
            ...
            enable_stackdriver_logging = true      
            ...
          }
    message: Ensure Datafusion has stack driver logging enabled.
    languages:
      - hcl
    severity: WARNING
    metadata:
      owasp:
        - A05:2017 - Broken Access Control
        - A01:2021 - Broken Access Control
      cwe:
        - "CWE-284: Improper Access Control"
      technology:
        - terraform
        - gcp
      category: security
      references:
        - https://owasp.org/Top10/A01_2021-Broken_Access_Control
      subcategory:
        - audit
      likelihood: LOW
      impact: LOW
      confidence: LOW
      license: Commons Clause License Condition v1.0[LGPL-2.1-only]
      vulnerability_class:
        - Improper Authorization

Examples

gcp-datafusion-stack-driver-logging.tf

# ok: gcp-datafusion-stack-driver-logging
resource "google_data_fusion_instance" "pass" {
  project                       = "examplea"
  provider                      = google-beta
  name                          = "my-instance"
  description                   = "My Data Fusion instance"
  region                        = "us-central1"
  type                          = "BASIC"
  enable_stackdriver_logging    = true
  enable_stackdriver_monitoring = true
  labels = {
    example_key = "example_value"
  }
  network_config {
    network       = "default"
    ip_allocation = "10.89.48.0/22"
  }
  version                  = "6.3.0"
  dataproc_service_account = data.google_app_engine_default_service_account.default.email
}

# fail
# ruleid: gcp-datafusion-stack-driver-logging
resource "google_data_fusion_instance" "fail" {
  project                       = "examplea"
  provider                      = google-beta
  name                          = "my-instance"
  description                   = "My Data Fusion instance"
  region                        = "us-central1"
  type                          = "BASIC"
  labels = {
    example_key = "example_value"
  }
  network_config {
    network       = "default"
    ip_allocation = "10.89.48.0/22"
  }
  version                  = "6.3.0"
  dataproc_service_account = data.google_app_engine_default_service_account.default.email
}

# fail
# ruleid: gcp-datafusion-stack-driver-logging
resource "google_data_fusion_instance" "fail2" {
  project                       = "examplea"
  provider                      = google-beta
  name                          = "my-instance"
  description                   = "My Data Fusion instance"
  region                        = "us-central1"
  type                          = "BASIC"
  enable_stackdriver_logging    = false
  enable_stackdriver_monitoring = false
  labels = {
    example_key = "example_value"
  }
  network_config {
    network       = "default"
    ip_allocation = "10.89.48.0/22"
  }
  version                  = "6.3.0"
  dataproc_service_account = data.google_app_engine_default_service_account.default.email
}