terraform.gcp.security.gcp-dataflow-private-job.gcp-dataflow-private-job

profile photo of semgrepsemgrep
Author
unknown
Download Count*
LGPL Commons Clause
License

Ensure Dataflow jobs are private

Run Locally

Run in CI

Semgrep CI docs

Defintion

Edit RuleView Source
Open in Playground 
rules:
  - id: gcp-dataflow-private-job
    patterns:
      - pattern: resource
      - pattern-inside: |
          resource "google_dataflow_job" "..." {
          ...
          }
      - pattern-not-inside: |
          resource "google_dataflow_job" "..." {
          ...
          ip_configuration = "WORKER_IP_PRIVATE"
          ...
          }
    message: Ensure Dataflow jobs are private
    metadata:
      owasp:
        - A05:2017 - Broken Access Control
        - A01:2021 - Broken Access Control
      cwe:
        - "CWE-284: Improper Access Control"
      category: security
      technology:
        - terraform
        - gcp
      references:
        - https://docs.bridgecrew.io/docs/google-cloud-policy-index
      subcategory:
        - audit
      likelihood: LOW
      impact: LOW
      confidence: LOW
      license: Commons Clause License Condition v1.0[LGPL-2.1-only]
      vulnerability_class:
        - Improper Authorization
    languages:
      - hcl
    severity: WARNING

Examples

gcp-dataflow-private-job.tf

# ok: gcp-dataflow-private-job
resource "google_dataflow_job" "pass" {
  name              = "my-pass-job"
  template_gcs_path = "gs://my-bucket/templates/template_file"
  temp_gcs_location = "gs://my-bucket/tmp_dir"
  parameters = {
    foo = "bar"
    baz = "qux"
  }
  ip_configuration = "WORKER_IP_PRIVATE"
}


# fail
# ruleid: gcp-dataflow-private-job
resource "google_dataflow_job" "fail1" {
  name              = "my-fail-job1"
  template_gcs_path = "gs://my-bucket/templates/template_file"
  temp_gcs_location = "gs://my-bucket/tmp_dir"
  parameters = {
    foo = "bar"
    baz = "qux"
  }

}

# fail
# ruleid: gcp-dataflow-private-job
resource "google_dataflow_job" "fail2" {
  name              = "my-fail-job2"
  template_gcs_path = "gs://my-bucket/templates/template_file"
  temp_gcs_location = "gs://my-bucket/tmp_dir"
  parameters = {
    foo = "bar"
    baz = "qux"
  }
  ip_configuration = "WORKER_IP_PUBLIC"
}