terraform.gcp.security.gcp-compute-serial-ports.gcp-compute-serial-ports

profile photo of semgrepsemgrep
Author
unknown
Download Count*
LGPL Commons Clause
License

Ensure 'Enable connecting to serial ports' is not enabled for VM Instance

Run Locally

Run in CI

Semgrep CI docs

Defintion

Edit RuleView Source
Open in Playground 
rules:
  - id: gcp-compute-serial-ports
    patterns:
      - pattern: resource
      - pattern-inside: |
          resource "google_compute_instance" "..." {
          ...
          metadata = {
              serial-port-enable = true
          }
          ...
          }
    message: "Ensure 'Enable connecting to serial ports' is not enabled for VM
      Instance\t"
    metadata:
      owasp:
        - A05:2017 - Broken Access Control
        - A01:2021 - Broken Access Control
      cwe:
        - "CWE-284: Improper Access Control"
      category: security
      technology:
        - terraform
        - gcp
      references:
        - https://docs.bridgecrew.io/docs/google-cloud-policy-index
      subcategory:
        - audit
      likelihood: LOW
      impact: LOW
      confidence: LOW
      license: Commons Clause License Condition v1.0[LGPL-2.1-only]
      vulnerability_class:
        - Improper Authorization
    languages:
      - hcl
    severity: WARNING

Examples

gcp-compute-serial-ports.tf

# fail
# ruleid: gcp-compute-serial-ports
resource "google_compute_instance" "fail" {
    name         = "test"
    machine_type = "n1-standard-1"
    zone         = "us-central1-a"
    boot_disk {}
    metadata = {
        serial-port-enable = true
    }
}

# ok: gcp-compute-serial-ports
resource "google_compute_instance" "success1" {
    name         = "test"
    machine_type = "n1-standard-1"
    zone         = "us-central1-a"
    boot_disk {}
}

# ok: gcp-compute-serial-ports
resource "google_compute_instance" "success2" {
    name         = "test"
    machine_type = "n1-standard-1"
    zone         = "us-central1-a"
    boot_disk {}
    metadata = {
        serial-port-enable = false
    }
}