terraform.gcp.security.gcp-compute-project-os-login.gcp-compute-project-os-login

profile photo of semgrepsemgrep
Author
unknown
Download Count*
LGPL Commons Clause
License

Ensure oslogin is enabled for a Project

Run Locally

Run in CI

Semgrep CI docs

Defintion

Edit RuleView Source
Open in Playground 
rules:
  - id: gcp-compute-project-os-login
    patterns:
      - pattern: resource
      - pattern-inside: |
          resource "google_compute_project_metadata" "..." {
          ...
          }
      - pattern-not-inside: |
          resource "google_compute_project_metadata" "..." {
          ...
          metadata = {
              enable-oslogin = "True"
          }
          ...
          }
      - pattern-not-inside: |
          resource "google_compute_project_metadata" "..." {
          ...
          metadata = {
              enable-oslogin = True
          }
          ...
          }
    message: "Ensure oslogin is enabled for a Project\t"
    metadata:
      owasp:
        - A05:2017 - Broken Access Control
        - A01:2021 - Broken Access Control
      cwe:
        - "CWE-284: Improper Access Control"
      category: security
      technology:
        - terraform
        - gcp
      references:
        - https://docs.bridgecrew.io/docs/google-cloud-policy-index
      subcategory:
        - audit
      likelihood: LOW
      impact: LOW
      confidence: LOW
      license: Commons Clause License Condition v1.0[LGPL-2.1-only]
      vulnerability_class:
        - Improper Authorization
    languages:
      - hcl
    severity: WARNING

Examples

gcp-compute-project-os-login.tf

# fail
# ruleid: gcp-compute-project-os-login
resource "google_compute_project_metadata" "fail" {
  metadata = {
    foo = "bar"
  }
}

# ok: gcp-compute-project-os-login
resource "google_compute_project_metadata" "pass" {
  metadata = {
    foo            = "bar"
    enable-oslogin = "True"
  }
}

# ok: gcp-compute-project-os-login
resource "google_compute_project_metadata" "pass" {
  metadata = {
    foo            = "bar"
    enable-oslogin = True
  }
}