terraform.gcp.security.gcp-build-workers-private.gcp-build-workers-private

profile photo of semgrepsemgrep
Author
unknown
Download Count*

Ensure Cloud build workers are private

Run Locally

Run in CI

Defintion

rules:
  - id: gcp-build-workers-private
    patterns:
      - pattern: resource
      - pattern-inside: |
          resource "google_cloudbuild_worker_pool" "..." {
          ...
          }
      - pattern-not-inside: |
          resource "google_cloudbuild_worker_pool" "..." {
          ...
          worker_config {
            ...
            no_external_ip = true
            ...
          }
          ...
          }
    message: "Ensure Cloud build workers are private\t"
    metadata:
      owasp:
        - A05:2017 - Broken Access Control
        - A01:2021 - Broken Access Control
      cwe:
        - "CWE-284: Improper Access Control"
      category: security
      technology:
        - terraform
        - gcp
      references:
        - https://docs.bridgecrew.io/docs/google-cloud-policy-index
      subcategory:
        - audit
      likelihood: LOW
      impact: LOW
      confidence: LOW
      license: Commons Clause License Condition v1.0[LGPL-2.1-only]
      vulnerability_class:
        - Improper Authorization
    languages:
      - hcl
    severity: WARNING

Examples

gcp-build-workers-private.tf

# fail
# ruleid: gcp-build-workers-private
resource "google_cloudbuild_worker_pool" "fail1" {
  name = "my-pool"
  location = "europe-west1"
  worker_config {
    disk_size_gb = 100
    machine_type = "e2-standard-4"
    no_external_ip = false
  }
}

# fail
# ruleid: gcp-build-workers-private
resource "google_cloudbuild_worker_pool" "fail2" {
  name = "my-pool"
  location = "europe-west1"
  worker_config {
    disk_size_gb = 100
    machine_type = "e2-standard-4"
  }
}

# ok: gcp-build-workers-private
resource "google_cloudbuild_worker_pool" "pass" {
  name = "my-pool"
  location = "europe-west1"
  worker_config {
    disk_size_gb = 100
    machine_type = "e2-standard-4"
    no_external_ip = true
  }
}