terraform.azure.security.azure-storage-sync-public-access-disabled.azure-storage-sync-public-access-disabled

profile photo of semgrepsemgrep
Author
unknown
Download Count*
LGPL Commons Clause
License

Ensure that Azure File Sync disables public network access

Run Locally

Run in CI

Semgrep CI docs

Defintion

Edit RuleView Source
Open in Playground 
rules:
  - id: azure-storage-sync-public-access-disabled
    message: Ensure that Azure File Sync disables public network access
    patterns:
      - pattern: resource
      - pattern-inside: |
          resource "azurerm_storage_sync" "..." {
          ...
          }
      - pattern-not-inside: |
          resource "azurerm_storage_sync" "..." {
          ...
          incoming_traffic_policy = AllowVirtualNetworksOnly
          ...
          }
    metadata:
      owasp:
        - A05:2017 - Broken Access Control
        - A01:2021 - Broken Access Control
      cwe:
        - "CWE-284: Improper Access Control"
      category: security
      technology:
        - terraform
        - azure
      references:
        - https://owasp.org/Top10/A01_2021-Broken_Access_Control
      subcategory:
        - audit
      likelihood: LOW
      impact: LOW
      confidence: LOW
      license: Commons Clause License Condition v1.0[LGPL-2.1-only]
      vulnerability_class:
        - Improper Authorization
    languages:
      - hcl
    severity: WARNING

Examples

azure-storage-sync-public-access-disabled.tf

# fail
# ruleid: azure-storage-sync-public-access-disabled
resource "azurerm_storage_sync" "test" {
    name                = "example-storage-sync"
    resource_group_name = azurerm_resource_group.test.name
    location            = azurerm_resource_group.test.location
    tags = {
    foo = "bar"
    }
}

# fail
# ruleid: azure-storage-sync-public-access-disabled
resource "azurerm_storage_sync" "test" {
    name                = "example-storage-sync"
    resource_group_name = azurerm_resource_group.test.name
    location            = azurerm_resource_group.test.location
    incoming_traffic_policy = "AllowAllTraffic"
    tags = {
    foo = "bar"
    }
}

# pass
resource "azurerm_storage_sync" "test" {
    name                = "example-storage-sync"
    resource_group_name = azurerm_resource_group.test.name
    location            = azurerm_resource_group.test.location
    incoming_traffic_policy = AllowVirtualNetworksOnly
    tags = {
    foo = "bar"
    }
}