terraform.azure.security.azure-storage-account-disable-public-access.azure-storage-account-disable-public-access

profile photo of semgrepsemgrep
Author
unknown
Download Count*
LGPL Commons Clause
License

Ensure default network access rule for Storage Accounts is set to deny

Run Locally

Run in CI

Semgrep CI docs

Defintion

Edit RuleView Source
Open in Playground 
rules:
  - id: azure-storage-account-disable-public-access
    message: Ensure default network access rule for Storage Accounts is set to deny
    patterns:
      - pattern: resource
      - pattern-inside: |
          resource "azurerm_storage_account" "..." {
          ...
          allow_blob_public_access = true
          ...
          }
    metadata:
      owasp:
        - A05:2017 - Broken Access Control
        - A01:2021 - Broken Access Control
      cwe:
        - "CWE-284: Improper Access Control"
      category: security
      technology:
        - terraform
        - azure
      references:
        - https://owasp.org/Top10/A01_2021-Broken_Access_Control
      subcategory:
        - audit
      likelihood: LOW
      impact: LOW
      confidence: LOW
      license: Commons Clause License Condition v1.0[LGPL-2.1-only]
      vulnerability_class:
        - Improper Authorization
    languages:
      - hcl
    severity: WARNING

Examples

azure-storage-account-disable-public-access.tf

# fail
# ruleid: azure-storage-account-disable-public-access
resource "azurerm_storage_account" "example" {
    name                     = "storageaccountname"
    resource_group_name      = azurerm_resource_group.example.name
    location                 = azurerm_resource_group.example.location
    account_tier             = "Standard"
    account_replication_type = "GRS"
    enable_https_traffic_only = false
    allow_blob_public_access = true

    tags = {
    environment = "staging"
    }
}

# pass
resource "azurerm_storage_account" "example" {
    name                     = "storageaccountname"
    resource_group_name      = azurerm_resource_group.example.name
    location                 = azurerm_resource_group.example.location
    account_tier             = "Standard"
    account_replication_type = "GRS"

    tags = {
    environment = "staging"
    }
}

# pass
resource "azurerm_storage_account" "example" {
    name                     = "storageaccountname"
    resource_group_name      = azurerm_resource_group.example.name
    location                 = azurerm_resource_group.example.location
    account_tier             = "Standard"
    account_replication_type = "GRS"
    allow_blob_public_access = false

    tags = {
    environment = "staging"
    }
}