terraform.azure.security.appservice.appservice-use-secure-tls-policy.appservice-use-secure-tls-policy

profile photo of semgrepsemgrep
Author
unknown
Download Count*
LGPL Commons Clause
License

Detected an AppService that was not configured to use TLS 1.2. Add site_config.min_tls_version = "1.2" in your resource block.

Run Locally

Run in CI

Semgrep CI docs

Defintion

Edit RuleView Source
Open in Playground 
rules:
  - id: appservice-use-secure-tls-policy
    message: Detected an AppService that was not configured to use TLS 1.2. Add
      `site_config.min_tls_version = "1.2"` in your resource block.
    patterns:
      - pattern: min_tls_version = $ANYTHING
      - pattern-inside: |
          resource "azurerm_app_service" "$NAME" {
            ...
          }
      - pattern-not-inside: min_tls_version = "1.2"
    metadata:
      cwe:
        - "CWE-326: Inadequate Encryption Strength"
      category: security
      technology:
        - terraform
        - azure
      references:
        - https://registry.terraform.io/providers/hashicorp/azurerm/latest/docs/resources/app_service#min_tls_version
      owasp:
        - A03:2017 - Sensitive Data Exposure
        - A02:2021 - Cryptographic Failures
      subcategory:
        - vuln
      likelihood: LOW
      impact: MEDIUM
      confidence: HIGH
      license: Commons Clause License Condition v1.0[LGPL-2.1-only]
      vulnerability_class:
        - Cryptographic Issues
    languages:
      - hcl
    severity: ERROR

Examples

appservice-use-secure-tls-policy.tf

# pass

resource "azurerm_app_service" "good_example" {
  name                = "example-app-service"
  location            = azurerm_resource_group.example.location
  resource_group_name = azurerm_resource_group.example.name
  app_service_plan_id = azurerm_app_service_plan.example.id
}

resource "azurerm_app_service" "good_example" {
  name                = "example-app-service"
  location            = azurerm_resource_group.example.location
  resource_group_name = azurerm_resource_group.example.name
  app_service_plan_id = azurerm_app_service_plan.example.id

  site_config {
      min_tls_version = "1.2"
  }
}

# fail

resource "azurerm_app_service" "bad_example" {
  name                = "example-app-service"
  location            = azurerm_resource_group.example.location
  resource_group_name = azurerm_resource_group.example.name
  app_service_plan_id = azurerm_app_service_plan.example.id

  site_config {
    # ruleid: appservice-use-secure-tls-policy
      min_tls_version = "1.0"
  }
}

resource "azurerm_app_service" "bad_example" {
  name                = "example-app-service"
  location            = azurerm_resource_group.example.location
  resource_group_name = azurerm_resource_group.example.name
  app_service_plan_id = azurerm_app_service_plan.example.id

  site_config {
    # ruleid: appservice-use-secure-tls-policy
      min_tls_version = "1.1"
  }
}

# not an azure resource

resource "google_compute_ssl_policy" "modern_TLS_policy" {
  # ok: appservice-use-secure-tls-policy
  min_tls_version = "TLS_1_2"
  name            = "modern-ssl-policy"
  profile         = "MODERN"
}