terraform.azure.security.appservice.appservice-require-client-cert.appservice-require-client-cert

profile photo of semgrepsemgrep
Author
unknown
Download Count*
LGPL Commons Clause
License

Detected an AppService that was not configured to use a client certificate. Add client_cert_enabled = true in your resource block.

Run Locally

Run in CI

Semgrep CI docs

Defintion

Edit RuleView Source
Open in Playground 
rules:
  - id: appservice-require-client-cert
    message: Detected an AppService that was not configured to use a client
      certificate. Add `client_cert_enabled = true` in your resource block.
    patterns:
      - pattern: resource
      - pattern-not-inside: |
          resource "azurerm_app_service" "..." {
          ...
            client_cert_enabled = true
          ...
          }
      - pattern-either:
          - pattern-inside: |
              resource "azurerm_app_service" "..." {
              ...
              }
          - pattern-inside: |
              resource "azurerm_app_service" "..." {
              ...
                client_cert_enabled = false
              ...
              }
    metadata:
      cwe:
        - "CWE-295: Improper Certificate Validation"
      category: security
      technology:
        - terraform
        - azure
      references:
        - https://registry.terraform.io/providers/hashicorp/azurerm/latest/docs/resources/app_service#client_cert_enabled
      owasp:
        - A03:2017 - Sensitive Data Exposure
        - A07:2021 - Identification and Authentication Failures
      subcategory:
        - vuln
      likelihood: MEDIUM
      impact: MEDIUM
      confidence: MEDIUM
      license: Commons Clause License Condition v1.0[LGPL-2.1-only]
      vulnerability_class:
        - Improper Authentication
    languages:
      - hcl
    severity: INFO

Examples

appservice-require-client-cert.tf

# pass

resource "azurerm_app_service" "good_example" {
  name                = "example-app-service"
  location            = azurerm_resource_group.example.location
  resource_group_name = azurerm_resource_group.example.name
  app_service_plan_id = azurerm_app_service_plan.example.id
  client_cert_enabled = true
}

# fail

# ruleid: appservice-require-client-cert
resource "azurerm_app_service" "bad_example" {
  name                = "example-app-service"
  location            = azurerm_resource_group.example.location
  resource_group_name = azurerm_resource_group.example.name
  app_service_plan_id = azurerm_app_service_plan.example.id
  client_cert_enabled = false
}

# ruleid: appservice-require-client-cert
resource "azurerm_app_service" "bad_example" {
  name                = "example-app-service"
  location            = azurerm_resource_group.example.location
  resource_group_name = azurerm_resource_group.example.name
  app_service_plan_id = azurerm_app_service_plan.example.id
}