terraform.azure.security.apiservice.azure-apiservices-use-virtualnetwork.azure-apiservices-use-virtualnetwork

profile photo of semgrepsemgrep
Author
unknown
Download Count*
LGPL Commons Clause
License

Ensure that API management services use virtual networks

Run Locally

Run in CI

Semgrep CI docs

Defintion

Edit RuleView Source
Open in Playground 
rules:
  - id: azure-apiservices-use-virtualnetwork
    message: Ensure that API management services use virtual networks
    patterns:
      - pattern: resource
      - pattern-not-inside: |
          resource "azurerm_api_management" "..." {
          ...
          virtual_network_configuration {
            subnet_id = ...
          }
          ...
          }
      - pattern-inside: |
          resource "azurerm_api_management" "..." {
          ...
          }
    metadata:
      owasp:
        - A05:2017 - Broken Access Control
        - A01:2021 - Broken Access Control
      cwe:
        - "CWE-284: Improper Access Control"
      category: security
      technology:
        - terraform
        - azure
      references:
        - https://owasp.org/Top10/A01_2021-Broken_Access_Control
      subcategory:
        - audit
      likelihood: LOW
      impact: LOW
      confidence: LOW
      license: Commons Clause License Condition v1.0[LGPL-2.1-only]
      vulnerability_class:
        - Improper Authorization
    languages:
      - hcl
    severity: WARNING

Examples

azure-apiservices-use-virtualnetwork.tf

# fail
# ruleid: azure-apiservices-use-virtualnetwork
resource "azurerm_api_management" "example" {
    name                = "example-apim"
    location            = azurerm_resource_group.example.location
    resource_group_name = azurerm_resource_group.example.name
    publisher_name      = "My Company"
    publisher_email     = "company@terraform.io"

    sku_name = "Developer_1"

    policy {
    xml_content = <<XML
    <policies>
        <inbound />
        <backend />
        <outbound />
        <on-error />
    </policies>
XML

    }
}

# pass
resource "azurerm_api_management" "example" {
    name                = "example-apim"
    location            = azurerm_resource_group.example.location
    resource_group_name = azurerm_resource_group.example.name
    publisher_name      = "My Company"
    publisher_email     = "company@terraform.io"

    sku_name = "Developer_1"
    virtual_network_configuration {
    subnet_id = azure_subnet.subnet_not_public_ip.id
    }
    policy {
    xml_content = <<XML
    <policies>
        <inbound />
        <backend />
        <outbound />
        <on-error />
    </policies>
XML

    }
}