terraform.azure.best-practice.azure-appservice-used-azure-files.azure-appservice-used-azure-files

profile photo of semgrepsemgrep
Author
unknown
Download Count*

Ensure that app services use Azure Files

Run Locally

Run in CI

Defintion

rules:
  - id: azure-appservice-used-azure-files
    message: Ensure that app services use Azure Files
    patterns:
      - pattern: resource
      - pattern-not-inside: |
          resource "azurerm_app_service" "..." {
          ...
          storage_account {
            ...
            type = "AzureFiles"
            ...
          }
          ...
          }
      - pattern-inside: |
          resource "azurerm_app_service" "..." {
          ...
          }
    metadata:
      category: best-practice
      technology:
        - terraform
        - azure
      license: Commons Clause License Condition v1.0[LGPL-2.1-only]
    languages:
      - hcl
    severity: INFO

Examples

azure-appservice-used-azure-files.tf

# fail
# ruleid: azure-appservice-used-azure-files
resource "azurerm_app_service" "example" {
  name                = "example-app-service"
  location            = azurerm_resource_group.example.location
  resource_group_name = azurerm_resource_group.example.name
  app_service_plan_id = azurerm_app_service_plan.example.id
  https_only          = true
  storage_account {
    name = "test_name"
    type = "AzureBlob"
    account_name ="test_account_name"
    share_name = "test_share_name"
    access_key = "test_access_key"
  }
}

# fail
# ruleid: azure-appservice-used-azure-files
resource "azurerm_app_service" "example" {
  name                = "example-app-service"
  location            = azurerm_resource_group.example.location
  resource_group_name = azurerm_resource_group.example.name
  app_service_plan_id = azurerm_app_service_plan.example.id
  https_only          = true
  site_config {
    scm_type                 = "someValue"
  }
}

# pass
resource "azurerm_app_service" "example" {
    name                = "example-app-service"
  location            = azurerm_resource_group.example.location
  resource_group_name = azurerm_resource_group.example.name
  app_service_plan_id = azurerm_app_service_plan.example.id
  https_only          = true
  storage_account {
    name = "test_name"
    type = "AzureFiles"
    account_name ="test_account_name"
    share_name = "test_share_name"
    access_key = "test_access_key"
  }
}