python.sqlalchemy.performance.performance-improvements.batch-import

profile photo of semgrepsemgrep
Author
7,173
Download Count*
LGPL Commons Clause
License

Rather than adding one element at a time, consider batch loading to improve performance.

Run Locally

Run in CI

Semgrep CI docs

Defintion

Edit RuleView Source
Open in Playground 
rules:
  - id: batch-import
    pattern: |
      for $X in $Y:
        db.session.add($Z)
    message: Rather than adding one element at a time, consider batch loading to
      improve performance.
    languages:
      - python
    severity: WARNING
    metadata:
      category: performance
      technology:
        - sqlalchemy
      license: Commons Clause License Condition v1.0[LGPL-2.1-only]

Examples

performance-improvements.py

# ruleid:batch-import
for song in songs:
    db.session.add(song)

# ruleid:len-all-count
len(persons.all())