python.lang.maintainability.useless-literal.useless-literal-dict

Verifed by r2c
Community Favorite
profile photo of returntocorpreturntocorp
Author
106,831
Download Count*
LGPL Commons Clause
License

key $X is uselessly assigned twice

Run Locally

Run in CI

Semgrep CI docs

Defintion

Edit RuleView Source
Open in Playground 
rules:
  - id: useless-literal-dict
    message: key `$X` is uselessly assigned twice
    languages:
      - python
    severity: WARNING
    pattern-either:
      - pattern: |
          {..., $X: $A, ..., $X: $B, ...}
      - pattern: |
          dict(..., ($X, $A), ..., ($X, $B), ...)
    metadata:
      category: maintainability
      technology:
        - python
      license: Commons Clause License Condition v1.0[LGPL-2.1-only]

Examples

useless-literal.py

# ruleid: useless-literal-dict
d = dict((1, 'a'), (2, 'b'), (1, 'a'))
# ruleid: useless-literal-set
s = set((1, 'a'), (2, 'b'), (1, 'a'))

# ruleid: useless-literal-dict
d = {1: 'a', 2: 'b', 1: 'a'}
# ruleid: useless-literal-dict
d = {'a': 1, 'a': 1}

# ok: useless-literal-dict
d = {1: 'a', 2: 'b', 3: 'a'}