python.lang.maintainability.useless-ifelse.useless-if-conditional

Verifed by r2c
Community Favorite
profile photo of returntocorpreturntocorp
Author
106,831
Download Count*
LGPL Commons Clause
License

if block checks for the same condition on both branches ($X)

Run Locally

Run in CI

Semgrep CI docs

Defintion

Edit RuleView Source
Open in Playground 
rules:
  - id: useless-if-conditional
    message: if block checks for the same condition on both branches (`$X`)
    languages:
      - python
    severity: WARNING
    pattern: |
      if $X:
          ...
      elif $X:
          ...
    metadata:
      references:
        - https://docs.python.org/3/tutorial/controlflow.html
      category: maintainability
      technology:
        - python
      license: Commons Clause License Condition v1.0[LGPL-2.1-only]

Examples

useless-ifelse.py

a, b, c = 1

# ruleid: useless-if-conditional
if a:
    print('1')
elif a:
    print('2')

# ruleid: useless-if-body
if a:
    print('1')
else:
    print('1')

# a and b are different cases -- ok
if a:
    print('1')
elif b:
    print('1')


# don't report on cases like this
if a:
    print('this is a')
elif b:
    print('this is b')
elif c:
    print('this is c')
elif d:
    print('this is d')


# don't report on cases like this
if a:
    print('this is a')
elif b:
    print('this is b')
elif c:
    print('this is b')