problem-based-packs.insecure-transport.js-node.disallow-old-tls-versions1.disallow-old-tls-versions1

profile photo of returntocorpreturntocorp
Author
2,021
Download Count*
LGPL Commons Clause
License

Detects direct creations of $HTTPS servers that don't disallow SSL v2, SSL v3, and TLS v1. These protocols are deprecated due to POODLE, man in the middle attacks, and other vulnerabilities.

Run Locally

Run in CI

Semgrep CI docs

Defintion

Edit RuleView Source
Open in Playground 
rules:
  - id: disallow-old-tls-versions1
    message: Detects direct creations of $HTTPS servers that don't disallow SSL v2,
      SSL v3, and TLS v1. These protocols are deprecated due to POODLE, man in
      the middle attacks, and other vulnerabilities.
    severity: WARNING
    metadata:
      likelihood: MEDIUM
      impact: MEDIUM
      confidence: MEDIUM
      category: security
      cwe: "CWE-319: Cleartext Transmission of Sensitive Information"
      owasp: A03:2017 - Sensitive Data Exposure
      references:
        - https://us-cert.cisa.gov/ncas/alerts/TA14-290A
        - https://stackoverflow.com/questions/40434934/how-to-disable-the-ssl-3-0-and-tls-1-0-in-nodejs
        - https://nodejs.org/api/https.html#https_https_createserver_options_requestlistener
      subcategory:
        - vuln
      technology:
        - node.js
      vulnerability: Insecure Transport
      license: Commons Clause License Condition v1.0[LGPL-2.1-only]
      vulnerability_class:
        - Mishandled Sensitive Information
    languages:
      - javascript
      - typescript
    patterns:
      - pattern-either:
          - pattern-inside: |
              $CONST = require('crypto');
              ...
          - pattern-inside: |
              $CONST = require('constants');
              ...
      - pattern-inside: |
          $HTTPS = require('https');
          ...
      - pattern: |
          $HTTPS.createServer(...).$FUNC(...);
      - pattern-not: >
          $HTTPS.createServer({secureOptions: $CONST.SSL_OP_NO_TLSv1 |
          $CONST.SSL_OP_NO_SSLv3 | $CONST.SSL_OP_NO_SSLv2 }, ...).$FUNC(...);
      - pattern-not: >
          $HTTPS.createServer({secureOptions: $CONST.SSL_OP_NO_TLSv1 |
          $CONST.SSL_OP_NO_SSLv2 |$CONST.SSL_OP_NO_SSLv3 }, ...).$FUNC(...);
      - pattern-not: >
          $HTTPS.createServer({secureOptions: $CONST.SSL_OP_NO_SSLv2
          |$CONST.SSL_OP_NO_SSLv3 |$CONST.SSL_OP_NO_TLSv1 }, ...).$FUNC(...);
      - pattern-not: >
          $HTTPS.createServer({secureOptions: $CONST.SSL_OP_NO_SSLv2
          |$CONST.SSL_OP_NO_TLSv1 | $CONST.SSL_OP_NO_SSLv3}, ...).$FUNC(...);
      - pattern-not: >
          $HTTPS.createServer({secureOptions:$CONST.SSL_OP_NO_SSLv3 |
          $CONST.SSL_OP_NO_SSLv2 |$CONST.SSL_OP_NO_TLSv1}, ...).$FUNC(...);
      - pattern-not: >
          $HTTPS.createServer({secureOptions:$CONST.SSL_OP_NO_SSLv3 |
          $CONST.SSL_OP_NO_TLSv1| $CONST.SSL_OP_NO_SSLv2}, ...).$FUNC(...);

Examples

disallow-old-tls-versions1.js

const https = require('https');

function ok1() {
    const constants = require('crypto');
    // ok: disallow-old-tls-versions1
    https.createServer({
        secureOptions: constants.SSL_OP_NO_TLSv1 | constants.SSL_OP_NO_SSLv3  | constants.SSL_OP_NO_SSLv2
    }, app).listen(443);
}

function ok2() {
    const consts = require('crypto');
    // ok: disallow-old-tls-versions1
    https.createServer({
        secureOptions: consts.SSL_OP_NO_TLSv1 | consts.SSL_OP_NO_SSLv3  | consts.SSL_OP_NO_SSLv2
    }, app).listen(443);
}

function ok3() {
    const consts = require('crypto');
    // ok: disallow-old-tls-versions1
    https.createServer({
        secureOptions: consts.SSL_OP_NO_SSLv3  | consts.SSL_OP_NO_SSLv2 |  consts.SSL_OP_NO_TLSv1
    }, app).listen(443);
}

function ok4() {
    const consts = require('constants');
    // ok: disallow-old-tls-versions1
    https.createServer({
        secureOptions: consts.SSL_OP_NO_SSLv3  | consts.SSL_OP_NO_SSLv2 |  consts.SSL_OP_NO_TLSv1
    }, app).listen(443);
}

function bad1() {
    const consts = require('crypto');
    // ruleid: disallow-old-tls-versions1
    https.createServer({
        secureOptions: consts.SSL_OP_NO_TLSv1 | consts.SSL_OP_NO_SSLv3
    }, app).listen(443);
}

function bad2() {
    const consts = require('crypto');
    // ruleid: disallow-old-tls-versions1
    https.createServer({
        secureOptions: consts.SSL_OP_NO_TLSv1
    }, app).listen(443);
}

function bad3() {
    const consts = require('crypto');
    // ruleid: disallow-old-tls-versions1
    https.createServer({ oops: oops
    }, app).listen(443);
}

function bad4() {
    const consts = require('constants');
    // ruleid: disallow-old-tls-versions1
    https.createServer({ oops: oops
    }, app).listen(443);
}