kotlin.lang.security.unencrypted-socket.unencrypted-socket

profile photo of semgrepsemgrep
Author
unknown
Download Count*
LGPL Commons Clause
License

This socket is not encrypted. The traffic could be read by an attacker intercepting the network traffic. Use an SSLSocket created by 'SSLSocketFactory' or 'SSLServerSocketFactory' instead

Run Locally

Run in CI

Semgrep CI docs

Defintion

Edit RuleView Source
Open in Playground 
rules:
  - id: unencrypted-socket
    metadata:
      cwe:
        - "CWE-319: Cleartext Transmission of Sensitive Information"
      owasp:
        - A03:2017 - Sensitive Data Exposure
        - A02:2021 - Cryptographic Failures
      source-rule-url: https://find-sec-bugs.github.io/bugs.htm#UNENCRYPTED_SOCKET
      asvs:
        section: V6 Stored Cryptography Verification Requirements
        control_id: 6.2.5 Insecure Algorithm
        control_url: https://github.com/OWASP/ASVS/blob/master/4.0/en/0x14-V6-Cryptography.md#v62-algorithms
        version: "4"
      category: security
      technology:
        - kotlin
      license: Commons Clause License Condition v1.0[LGPL-2.1-only]
      references:
        - https://owasp.org/Top10/A02_2021-Cryptographic_Failures
      subcategory:
        - audit
      likelihood: LOW
      impact: LOW
      confidence: LOW
      vulnerability_class:
        - Mishandled Sensitive Information
    message: This socket is not encrypted. The traffic could be read by an attacker
      intercepting the network traffic. Use an SSLSocket created by
      'SSLSocketFactory' or 'SSLServerSocketFactory' instead
    severity: WARNING
    languages:
      - kt
    pattern-either:
      - pattern: ServerSocket(...)
      - pattern: Socket(...)

Examples

unencrypted-socket.kt

package testcode.crypto

import javax.net.ssl.SSLServerSocketFactory
import java.io.*
import java.net.InetAddress
import java.net.Socket
import java.net.ServerSocket

public class UnencryptedSocket {

    fun sslSocket(): Void {
        // ok: unencrypted-socket
        val soc:Socket = SSLSocketFactory.getDefault().createSocket("www.google.com", 443)
        doGetRequest(soc)
    }

    fun plainSocket(): Void {
        // ruleid: unencrypted-socket
        val soc: Socket = Socket("www.google.com", 80)
        doGetRequest(soc)
    }

    fun byteArrayOfInts(vararg ints: Int) = ByteArray(ints.size) { pos -> ints[pos].toByte() }

    fun otherConstructors(): Void {
        // ruleid: unencrypted-socket
        val soc1: Socket = Socket("www.google.com", 80, true)
        doGetRequest(soc1)
        val address: ByteArray = byteArrayOfInts(127, 0, 0, 1)
        // ruleid: unencrypted-socket
        val soc2: Socket = Socket("www.google.com", 80, InetAddress.getByAddress(address), 13337)
        doGetRequest(soc2)
        val remoteAddress: ByteArray = byteArrayOfInts(74, 125, toByte(226), toByte(193))
        // ruleid: unencrypted-socket
        val soc3: Socket = Socket(InetAddress.getByAddress(remoteAddress), 80)
        doGetRequest(soc2)
    }

    fun doGetRequest(soc: Socket): Void {
        System.out.println("")
        soc.close()
    }
}

public class UnencryptedServerSocket {

    fun sslServerSocket(): Void {
        // ok: unencrypted-socket
        val ssoc: ServerSocket = SSLServerSocketFactory.getDefault().createServerSocket(1234)
        ssoc.close()
    }

    fun plainServerSocket(): Void {
        // ruleid: unencrypted-socket
        val ssoc: ServerSocket = ServerSocket(1234)
        ssoc.close()
    }

    fun byteArrayOfInts(vararg ints: Int) = ByteArray(ints.size) { pos -> ints[pos].toByte() }

    fun otherConstructors(): Void {
        // ruleid: unencrypted-socket
        val ssoc1: ServerSocket = ServerSocket()
        ssoc1.close()
        // ruleid: unencrypted-socket
        val ssoc2: ServerSocket = ServerSocket(1234, 10)
        ssoc2.close()
        val address: ByteArray = byteArrayOfInts(127, 0, 0, 1)
        // ruleid: unencrypted-socket
        val ssoc3: ServerSocket = ServerSocket(1234, 10, InetAddress.getByAddress(address))
        ssoc3.close()
    }

}